search

umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.53k stars 2.7k forks source link

Accessibility issues with V13 login screen customisations #15626

Open craigs100 opened 10 months ago

craigs100 commented 10 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.3

Bug summary

Several issues affecting the ability to brand the login screen successfully without causing accessibility issues

Specifics

WRT: https://github.com/umbraco/Umbraco-CMS/blob/v13/dev/src/Umbraco.Web.UI.Login/src/components/layouts/auth-layout.element.ts

Setting the --umb-login-primary-color to white causes the text AND the login button background to turn to white, which renders a button with white text on a white background. When hovering over the button, the background turns to blue whether you want it to or not.

There is no way to set the background image size. It's set at "cover". It would be helpful to have the choice between "cover" and "contain", particularly useful when the image is an svg.

There is no way to just have a logo without specifying a background image.

There is no way to change the colour of the forgotten password link & hover text.

While out of the box the login page design is very opinionated, it would only take a couple of extra changes to make it easier to brand. The login page is really part of the web site. It's what gives clients the cosy feeling that this is their site. Once you're logged in then Umbraco branding all the way.

Steps to reproduce

iaw docs: https://docs.umbraco.com/umbraco-cms/fundamentals/backoffice/login

Expected result / actual result

Would expect it to be possible to use corporate brand colour combinations without issue. Would expect to be able to just show a corporate logo on it's own without issue.

Actually impossible to use some colour combinations due to the way some element settings have been combined (primary colour being used for both main heading and login button background)

Actually impossible to show just a logo without setting a background image

Actually impossible to set background image size attribute.

In the attached screen dump I wanted the main text to be white but had to settle for black as otherwise the button wouldn't work. The hover colour should be changed as well but can't be done.

https://github.com/umbraco/Umbraco-CMS/assets/1143883/27dba8b5-5662-4aaa-b44c-fd0419b60fee

github-actions[bot] commented 10 months ago

Hi there @craigs100!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

iOvergaard commented 10 months ago

Hi @craigs100 and thanks for the report.

Wow, you have a lot of customizations on the login screen. Looks pretty!

Regarding your comments, I want to address something in general first; the refreshed login screen is now utilizing the Web Component APIs including Shadow DOM. The nature of Shadow DOM itself prohibits any CSS from crossing the encapsulation boundary, except for a few select properties (which you can see here). This will also be the case for the new Backoffice currently being built and slated for Umbraco 14.

As for your wishes, I agree. We should have a way to insert a logo without a background image, and we should also be able to change the text colors as well as the background image size.

I will mark this as up-for-grabs to see if anyone wants to hook on and add what they need before we get a chance to look at it. I suspect that people in the community will know best how they would like to customize the login screen.

github-actions[bot] commented 10 months ago

Hi @craigs100,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

craigs100 commented 10 months ago

Hi @iOvergaard, thanks for the explanation. It's not that I want absolute full control, it's just that I want sensible control. It's important to be able to change all colours, including hover states, to prevent accessibility issues, to be able to add a logo on it's own and it'd be nice to be able to switch the background image size "cover" to "contain". I mean, if you can do anything else then great. I used to like the way you could add a whole page background image and overlay with an alpha layer, but totally fine with what you have now if there's sufficient control over it. :)

JasonElkin commented 10 months ago

@craigs100, the login screen specific styles are just mapping variables across to the individual components.

e.g. from https://github.com/umbraco/Umbraco-CMS/blob/v13/dev/src/Umbraco.Web.UI.Login/src/components/layouts/auth-layout.element.ts

--uui-button-border-radius: var(--umb-login-button-border-radius, 45px);

Making this more customisable is just a case of mapping more of those variables over. e.g.

--uui-button-background-color: var(--umb-login-button-background-color)
--uui-button-background-color-hover: var(--umb-login-button-background-color-hover)

 // etc.

But with sensible defaults I guess.