github-actions[bot]
commented
9 months ago Hi there @marcemarc!
Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.
We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
- We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
- If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
- We'll replicate the issue to ensure that the problem is as described.
- We'll decide whether the behavior is an issue or if the behavior is intended.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.
Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:
Migaroez
marcemarc
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
13.1.0
Bug summary
The upgraded site has a MultinodeTreePicker it sets its start node using XPATH
$site//newsCategoryGroups
I didn't spot this when initially upgraded to V12, but maybe I missed it?, anyway the // notification means find the document type anywhere in the 'XML'. (it's what people use when they can't work out the XPATH properly :-P)
After upgrading to V13, an error is thrown 'XPathValue must be an XPathNavigator or string'.
Stack Trace:
at Umbraco.Cms.Core.Xml.XPath.NavigableNavigator.MoveToFirstChildProperty() at Umbraco.Cms.Core.Xml.XPath.NavigableNavigator.MoveToFirstChild() at MS.Internal.Xml.XPath.DescendantQuery.Advance() at MS.Internal.Xml.XPath.DocumentOrderQuery.Evaluate(XPathNodeIterator context) at System.Xml.XPath.XPathNavigator.Evaluate(XPathExpression expr, XPathNodeIterator context) at System.Xml.XPath.XPathNavigator.Select(XPathExpression expr) at Umbraco.Extensions.XPathNavigatorExtensions.Select(XPathNavigator navigator, String expression, XPathVariable[] variables) at Umbraco.Cms.Infrastructure.PublishedCache.ContentCache.GetSingleByXPath(Boolean preview, String xpath, XPathVariable[] vars) at Umbraco.Cms.Core.PublishedCache.PublishedCacheBase.GetSingleByXPath(String xpath, XPathVariable[] vars) at Umbraco.Cms.Infrastructure.PublishedContentQuery.ItemByXPath(String xpath, XPathVariable[] vars, IPublishedCache cache) at Umbraco.Cms.Infrastructure.PublishedContentQuery.ContentSingleAtXPath(String xpath, XPathVariable[] vars) at Umbraco.Cms.Web.BackOffice.Controllers.EntityController.GetByXPath(String query, Int32 nodeContextId, Nullable`1 parentId, UmbracoEntityTypes type) at lambda_method3220(Closure, Object, Object[]) at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync() at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted) at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync() --- End of stack trace from previous location --- at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context) at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted) at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync() --- End of stack trace from previous location --- at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|26_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
Workaround
If I update the XPATH to follow the structure of the site eg
$site/data/newsCategoryGroups
then it's just fine and dandy, no errors, works as expected.
And of course, why on earth are you using XPATH, when you have the lovely Dynamic Root Whizzy Thing - can confirm if I build the query using the Dynamic Root wizard then it's all fine.
And I've confirmed it's not an issue with how the DataType configuration is stored,if I switch back to using XPath, and compare the saved value in the database for the datatype to before it is the same.
So my hunch is it is just the use of // which is throwing things off...
Still there are only 43 instances of MultiNodeTreePickers using // on this project, ho hum!
Specifics
No response
Steps to reproduce
Add a Multinode Tree Picker to a site, use XPATH to set the start node and use the // in the XPATH notation
It should find the first instance matching the // query but instead it throws an error when you view a page in the backoffice using the property editor
switch it to use the single path notation XPATH query all is fine.
Expected result / actual result
It would be great if it just worked with // but if not just add it as a breaking change in the docs, so people can take account of it when migrating.