umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

Dragging mouse outside overlay and releasing closes overlay #15726

Open erlando opened 8 months ago

erlando commented 8 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.3.6

Bug summary

When clicking and holding the mouse inside an overlay and then dragging the mouse outside the overlay and releasing the button the overlay close method is triggered.

This is problematic if the overlay for instance contains a text area where users type and occasionally mark text with the mouse. It is then pretty easy to let the mouse stray outside the overlay when marking text and then having the overlay closed.

Specifics

No response

Steps to reproduce

Open an overlay in backoffice:

overlayService.open({
    view: "path/to/view.html",
    close: overlayService.close    
});

view.html

<div><span>Overlay</span></div>

Now click and hold the mouse button anywhere on the overlay. Drag the mouse outside and release the button. The overlay will close.

Expected result / actual result

The desired result of dragging the mouse outside an overlay would be that the overlay close method was not triggered.

The actual result is that the overlay close method is triggered and the overlay is closed as a consequence.

github-actions[bot] commented 8 months ago

Hi there @erlando!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

elit0451 commented 8 months ago

Hey @erlando 👋 Thanks for reaching out!

I will mark this up for grabs as we would like some help fixing this.

github-actions[bot] commented 8 months ago

Hi @erlando,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)