RTE macro being stripped out

umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.

https://umbraco.com

MIT License

4.47k stars 2.69k forks source link

RTE macro being stripped out #15903

Open shearer3000 opened 7 months ago

shearer3000 commented 7 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

Observed in Umbraco 13 including 13.1.1, 13.2.0

Bug summary

When adding a macro into the RTE and performing a save+publish on the page, the macro will seemingly disappear immediately from the WYSIWYG editor

Specifics

No response

Steps to reproduce

Investigating further, when adding the macro and inspecting the markup in chrome dev tools reveals the following markup (note the macro div within the p tag):

but if i click the 'view source code', then the markup is sansitised/reformatted (note not sitting within p the any longer)

Expected result / actual result

Expected results: inserting an RTE macro produces markup that will save and publish correctly Actual results: macro removed during save (unless 'viewing source' beforehand)

Is this already tracked as a known issue? I scanned the tracker but couldn't find an obvious one.

How can this be resolved?

github-actions[bot] commented 7 months ago

Hi there @shearer3000!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

andr317c commented 7 months ago

Hey! Thanks a lot for reporting this issue, I was unable to reproduce this on version 13.2.1. I tried reproducing the issue using the Login and Login status snippets for partial view macro files. afterwards, I inserted both Macros in a RTE. I was also able to render it: