rollback feature showing phantom/incorrect differences

shearer3000 commented 5 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.2.2

Bug summary

We have a property using the Rich Text Editor, and when looking through the various versions on the Rollback screen, it appears to be showing the content differences correctly (as expected), but is also [incorrectly] showing differences regarding the meta data. These meta data changes appear to be regarding the block configuration but this RTE doesn't have any blocks.

Specifics

No response

Steps to reproduce

given that the property currently has a value of "pineapple",

rollback 'current version' comparison:

older version comparison:

Expected result / actual result

expected: metadata/block config shouldn't show any differences as blocks aren't used in this RTE actual: metadata being reported as different in Rollback version comparison

github-actions[bot] commented 5 months ago

Hi there @shearer3000!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

Migaroez commented 1 month ago

Hey @shearer3000 I was able to reproduced in v13 and I think it has to do with the value the frontend has is different from what is actually stored by the backend, most likely some null values being stripped during (de)serialization.

Happy to report it is no longer an issue in v14

github-actions[bot] commented 1 month ago

Hi @shearer3000,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

umbraco / Umbraco-CMS