umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.37k stars 2.64k forks source link

Umbraco breaks HttpAttribute #16006

Closed wiedikerli closed 1 week ago

wiedikerli commented 3 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.1.1

Bug summary

When I create a controller which implements UmbracoApiController with a http route attribute with parameter, it cannot find the route (404). But when I change to implement ControllerBase and route it my self it works. Is there something wrong? In this documentation i says it should work.

Specifics

No response

Steps to reproduce

This does not work (404):

public class DictionaryController() : UmbracoApiController
{
    [Route("all/{area?}")]
    public IActionResult All(string? area)
    {
        ...
    }
}

This works:

[Route("umbraco/api/[controller]")]
public class DictionaryController() : ControllerBase
{
    [Route("all/{area?}")]
    public IActionResult All(string? area)
    {
        ...
    }
}

Expected result / actual result

I expect that i behaves the same.

github-actions[bot] commented 3 months ago

Hi there @ninjaonsafari!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

NguyenThuyLan commented 1 week ago

Thanks, @wiedikerli for reporting this issue. Unfortunately, I couldn't replicate the 404 error as you described. In the image below, I used UmbracoApiController similar to yours, and it worked fine. Perhaps you might consider adding the [HttpGet] attribute? I'll close this issue as I couldn't reproduce it.

image image