PublishedContent Null After v13.3 Upgrade

[joshanangelofgrace]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.3.0

Bug summary

We are upgrading a site from v12 to v13 and noticed one of our custom routes no longer works. I did some digging and found that for this route the PublishedContent on the request is null in v13 when it was not null in v12

v12:

v13:

Specifics

Note for your info this is the code of the controller:

on v12 the 'in' route/method was being correctly hit

in v13 this is not even hit and a 404 comes up on the site

[Route("contact")]
public class ContactController : RenderController
 {
     private readonly ILogger<RenderController> logger;
     private readonly CountryRepository countryRepository;
     private readonly ContactRepository contactRepository;
     private readonly IScopeProvider provider;
     private readonly IPersonalisationService personalisationService;
     private readonly IVariationContextAccessor variationContextAccessor;
     private readonly ServiceContext serviceContext;

     public ContactController(CountryRepository countryRepository, ContactRepository contactRepository,
                              IScopeProvider provider, IPersonalisationService personalisationService,
                              ILogger<RenderController> logger, ICompositeViewEngine compositeViewEngine,
                              IUmbracoContextAccessor umbracoContextAccessor,
                              IVariationContextAccessor variationContextAccessor, ServiceContext serviceContext)
         : base(logger, compositeViewEngine, umbracoContextAccessor)
     {
         this.variationContextAccessor = variationContextAccessor;
         this.serviceContext = serviceContext;
         this.countryRepository = countryRepository;
         this.contactRepository = contactRepository;
         this.provider = provider;
         this.personalisationService = personalisationService;
         this.logger = logger;
     }

     [Route("in/{countryKey}")]
     public IActionResult In(string countryKey)
     {
         logger.LogDebug("Retrieving information for country {countryKey}", countryKey);

         using (provider.CreateScope(autoComplete: true))
         {
             personalisationService.EnsureSessionProps(HttpContext);
             // ensure country URL uses ISO codes, and is lower case.
             var country = countryRepository.Find(countryKey);
             var sourceCountry = country;
             if (country == null)
             {
                 return new RedirectResult($"/contact/in/");
             }
             else if (countryKey != country.IsoKey.ToLower())
             {
                 return new RedirectResult($"/contact/in/{country.IsoKey.ToLower()}/");
             }

             var distributors = contactRepository.Get(ContactType.Distributor, sourceCountry).ToList();
             var reps = contactRepository.Get(ContactType.SalesRep, sourceCountry).ToList();

             if (distributors.Count + reps.Count == 0)
             {
                 // attempt to redirect
                 sourceCountry = countryRepository.FindRedirected(country);
                 distributors = contactRepository.Get(ContactType.Distributor, sourceCountry).ToList();
                 reps = contactRepository.Get(ContactType.SalesRep, sourceCountry).ToList();
             }
             if (distributors.Count + reps.Count == 0)
             {
                 // ignore redirect, expand to region
                 sourceCountry = country;
                 distributors = contactRepository.GetFromRegion(ContactType.Distributor, country.RegionName).ToList();
                 reps = contactRepository.GetFromRegion(ContactType.SalesRep, country.RegionName).ToList();
             }

             var model = new ContactPageViewModel(CurrentPage, new PublishedValueFallback(serviceContext, variationContextAccessor))
             {
                 IsCurrentCountry = personalisationService.UserSession.Country?.Code == country.IsoKey,
                 Country = country,
                 RedirectedTo = sourceCountry,
                 Distributors = distributors,
                 SalesReps = reps
             };

             logger.LogDebug("Country Information: {@Model}", model);

             return PartialView("CountryView", model);
         }
     }
 }

Steps to reproduce

Set up a custom route - note that this route has no content behind it.

See if the route is being hit correctly

Expected result / actual result

No response

[github-actions[bot]]

Hi there @joshanangelofgrace!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

[Migaroez]

Hey @joshanangelofgrace thank you for taking the time to supply this detailed report. A fjew questions:

• Are you sure you are running 13.3.0 and not 13.3.1 as the later has some changes regarding the routing.
• Could you try on 13.4.0 (or latest 13) as some fixes to similar setups as this were introduces at that point
• Is there a compelling reason why you are not using a VirtualPageController as these seem to be better fitted to what you want to achieve: a custom static route that is not bound to a content type but where you can supply a method that finds a piece of content for your route. VS using a RenderController that binds dynamically to all routes that are linked to a specific content type (name of the controller minus controller) with either the default template (index method) or a specific template NameOfTheTemplate method). By adding a static route attribute to theRenderControlleryou are basically removing the functionality from it that actually makes it aRenderController`.

Disclaimer: I updated your submission by adding the csharp identifier to the opening codebraces ```csharp which results in nicer formating and placed the closing code braces on their own line so the rest of your response is properly formatted