Open joshanangelofgrace opened 4 months ago
Hi there @joshanangelofgrace!
Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.
We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.
Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:
Hey @joshanangelofgrace thank you for taking the time to supply this detailed report. A fjew questions:
VirtualPageController
as these seem to be better fitted to what you want to achieve: a custom static route that is not bound to a content type but where you can supply a method that finds a piece of content for your route. VS using a RenderController
that binds dynamically to all routes that are linked to a specific content type (name of the controller minus controller
) with either the default template (index method) or a specific template NameOfTheTemplate method). By adding a static route attribute to the
RenderControlleryou are basically removing the functionality from it that actually makes it a
RenderController`.Disclaimer: I updated your submission by adding the csharp identifier to the opening codebraces ```csharp
which results in nicer formating and placed the closing code braces on their own line so the rest of your response is properly formatted
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
13.3.0
Bug summary
We are upgrading a site from v12 to v13 and noticed one of our custom routes no longer works. I did some digging and found that for this route the PublishedContent on the request is null in v13 when it was not null in v12
v12:![image](https://github.com/umbraco/Umbraco-CMS/assets/8406246/f16d6295-836e-47ab-9bc2-bf51ca4b2caf)
v13:![image](https://github.com/umbraco/Umbraco-CMS/assets/8406246/57855f34-b7fb-4941-9647-abbbc3b0435f)
Specifics
Note for your info this is the code of the controller:
on v12 the 'in' route/method was being correctly hit
in v13 this is not even hit and a 404 comes up on the site
Steps to reproduce
Set up a custom route - note that this route has no content behind it.
See if the route is being hit correctly
Expected result / actual result
No response