Macro not saving in chromium based browser

merlinmarijn commented 2 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.2.2

Bug summary

When trying to insert a macro into the rich text editor and saving or saving and publishing it wont save. but if you click back into the rich text editor before saving it does save. this only seems to happen for me in chromium based browsers

Specifics

Rich Text Editor

Steps to reproduce

Insert macro into rich text editor, click save or save and publish (without clicking back into the rich text editor) and the new macro doesn't get saved.

Expected result / actual result

That the macro gets saved in the rich text editor.

github-actions[bot] commented 2 months ago

Hi there @merlinmarijn!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

elit0451 commented 2 months ago

Hi @merlinmarijn 👋

Thanks for reaching out! Unfortunately, I wasn't able to reproduce this using the Google Chrome browser. Can you see if I am doing anything different than you:

https://github.com/umbraco/Umbraco-CMS/assets/21998037/04acbfec-8323-4e6a-9dc4-4bdb4e7564da

nul800sebastiaan commented 1 month ago

I think it only goes wrong if you've been typing in the RTE:

https://github.com/umbraco/Umbraco-CMS/assets/304656/5f352d3b-7230-4035-be87-899b90b6f175

sussexrick commented 1 month ago

This looks like a regression of https://github.com/umbraco/Umbraco-CMS/issues/7461

I've just seen it on a clean install of 13.3.0. I just created a single document type with a rich text editor using the default rich text editor data type, and rendered that on the template using the ModelsBuilder property. With this setup, if you use the embed button to insert a YouTube video, this bug happens.

AndersBrohus commented 3 weeks ago

It still occurs in 13.3.2 :(

The way to "fix" it is to click inside the RTE after the macro has been placed.

elit0451 commented 2 weeks ago

I will mark it as up for grabs since there is a workaround and we would like some help fixing this 🙂

github-actions[bot] commented 2 weeks ago

Hi @merlinmarijn,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

umbraco / Umbraco-CMS