umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.37k stars 2.64k forks source link

Microsoft.EntityFrameworkCore.Design missing? #16278

Closed TRexStark closed 2 months ago

TRexStark commented 2 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.3.0

Bug summary

I wanted to take the leap and try out v13 as most of our sites are still on v10. It's a fresh install with nothing in it at all, literally just the initial installation of Umbraco. I published the site to Folder and tried to run in in a live production server but kept getting a 500.30 error. The logs didn't provide any details besides the application shutting down. Then I thought I'll just review the publish setting and found an error stating that the startup project doesn't reference the Microsoft.EntityFrameworkCore.Design.

I'm not sure if I'm missing something or if this is a bug.

Specifics

No response

Steps to reproduce

Just initiate a clean install of Umbraco v13.3.0 and publish it to a production site.

Expected result / actual result

Shouldn't all base Microsoft dependencies required be as part of the installation?

github-actions[bot] commented 2 months ago

Hi there @TRexStark!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

ronaldbarendse commented 2 months ago

The Microsoft.EntityFrameworkCore.Design dependency is a design-time service and shouldn't be deployed with your application, see: https://learn.microsoft.com/en-us/ef/core/cli/services.

Umbraco only references it in the Umbraco.Web.UI project (the example/test site used for local CMS development), but that project is not packaged/published: https://github.com/umbraco/Umbraco-CMS/blob/b0b2b597403bb381c23ff47f2b1ffc8aeaab1dc0/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj#L14-L17

If you add a custom EF Core context and have added this dependency to create your own initial migrations, make sure to add the PrivateAssets="all" to the package reference as well!

TRexStark commented 2 months ago

Thanks @ronaldbarendse I literally just finished troubleshooting the issue and found the info you provided and realised that I had something messing around with my local setup after all.