V14-RC3: Publishing a page generates 2 toast notifications

PerplexDaniel commented 3 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0-rc3

Bug summary

When a page is published 2 toast notifications are shown, "Saved" and "Document published". This seems superfluous and was never the case in earlier versions. It may be on purpose but it looks a bit strange to me so that's why I create this issue.

Specifics

No response

Steps to reproduce

Publish any page
Observe 2 toast notifications are created

Expected result / actual result

I expect only 1 toast notification, either with "Document saved and published" or simply "Document published" which implies it is also saved.

github-actions[bot] commented 3 months ago

Hi there @PerplexDaniel!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

iOvergaard commented 3 months ago

Thanks for testing, @PerplexDaniel. I can reproduce this, but there are two actions happening, and one of them could fail without affecting the other, e.g. if your document fails validation, it is still saved as a new version. In V13 and before, you were not informed as a user about this fact even though it happened.

I am sure we can come up with a solution to combine results over several requests and inform the user about a partial success/failure in one notification.

enkelmedia commented 3 months ago

I think that the overall experience with notifications would benefit from from re-thinking.

Some ideas here: https://github.com/umbraco/Umbraco.CMS.Backoffice/issues/840

umbraco / Umbraco-CMS