umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.37k stars 2.64k forks source link

Breaking changes from V13 to V14 #16316

Open cmwalolo opened 2 months ago

cmwalolo commented 2 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.1.1

Bug summary

I'm trying to migrate 13.1.1 to 14. And I'm stuck as all breaking changes are not reported.

Specifics

For instance one of the breaking functions is :

var url = Url.GetUmbracoApiService<CrolowFormApiController>(_controllers, "InsertComment");

I don't find the correspondency of that function in V14 as some other functions. But I rolled back to V13, I fixed some compilation errors, but I still remained with a bunch of errors.

Steps to reproduce

Just upgrade an umbraco V13 to V14 :-)

Expected result / actual result

I have an application using V13.1.1 that compiles correctly, after upgrade and fixing the breaking changes as stated in the docs, I should be able to reuse my app as is !

github-actions[bot] commented 2 months ago

Hi there @cmwalolo!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

Zeegaan commented 1 week ago

Hmm, this should be in v14, it was reintroduced in this PR: https://github.com/umbraco/Umbraco-CMS/pull/16263 And it's in the sourcecode at least; image

Is this on the 14.0.0? 🤔 And where are you putting your var url = Url.GetUmbracoApiService<CrolowFormApiController>(_controllers, "InsertComment");, is this in a view somewhere or ? 😁

Some steps to reproduce this from scratch would be very helpful 🙏