Save button has border radius on one side

poornimanayar commented 4 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14 RC4

Bug summary

I dont know whether this is by design but the "Save" button in doc types have a bottom and top left border-radius but not on the right

Specifics

No response

Steps to reproduce

As above

Expected result / actual result

No response

github-actions[bot] commented 4 months ago

Hi there @poornimanayar!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

JoJk0 commented 4 months ago

Can confirm, it's more visible if CSS vars for corner radii is customized to be bigger.

leekelleher commented 4 months ago

@iOvergaard I think this may be an underlying issue with UUI library's <uui-button-group> component? https://uui.umbraco.com/?path=/docs/uui-button-group--docs

iOvergaard commented 2 months ago

Well, @leekelleher, this happens because the button group targets all elements regardless if they are buttons or not.

If you look at the DOM, you will see the host element for the little popup menu being present, and that it, in fact, gets the missing border radii attached, but since it is not a visible element if there are no items attached, it doesn't show the borders.

The solution is to either hide the element in the Backoffice, if there are no sub-menu-actions, or to ensure that UUI only targets "buttons", but I would be sorry to have to guess what constitutes a button.

We will have to look more into it.

umbraco / Umbraco-CMS