umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.43k stars 2.67k forks source link

Umbraco Custom Property Validation -> SQLite vs SQL field length issue #16368

Open AaronSadlerUK opened 4 months ago

AaronSadlerUK commented 4 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.1.1

Bug summary

The field length in the database for the regex validation in a document type is not the same between SQL Lite and SQL. This causes a truncated exception to be thrown when trying to deploy.

Specifics

No response

Steps to reproduce

Create a new site (or use a new local Umbraco Cloud) using SQL Lite for the database Add a textstring property to a document type Set the validation to custom Enter the following regex ^(https?:\\/\\/)?((www|m)\\.)?(youtube\\.com\\/(watch\\?v=|embed\\/|v\\/)|youtu\\.be\\/|youtube\\.[a-z]{2,3}\\/(watch\\?v=|embed\\/|v\\/)|youtube-nocookie\\.com\\/(embed\\/)|vimeo\\.com\\/(channels\\/[A-Za-z0-9]+\\/videos\\/|groups\\/[A-Za-z0-9]+\\/videos\\/|video\\/)|vimeo\\.[a-z]{2,3}\\/(channels\\/[A-Za-z0-9]+\\/videos\\/|groups\\/[A-Za-z0-9]+\\/videos\\/|video\\/))([A-Za-z0-9_-]+)(\\?[A-Za-z0-9=&_-]*)?$ Deploy to Umbraco Cloud (or to a site using SQL)

Expected result / actual result

I would expect to be able to use the same length validation regex with SQL as with SQLite

Instead a truncated exception is thrown, the field type should be changed to NTEXT to resolve this

github-actions[bot] commented 4 months ago

Hi there @AaronSadlerUK!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

github-actions[bot] commented 15 hours ago

Hi @AaronSadlerUK,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)