v14-rc4 - media picker - click on item name does not work correct

mjpraxis commented 4 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14-rc4

Bug summary

In the Media Picker clicking on an item's name results with a strange message "There are no items to show in the list"

Specifics

No response

Steps to reproduce

Create document type with a media picker property

Create a Media item

Create Content and try to pick a Media item by clicking the title/name of the item.

chrome_cgMQGcRYV1

Expected result / actual result

Expected the media item was selected

Actual: The Media Picker thinks the item is a Folder Image shows that I click the "Test" item and now the breadcrumb shows that the picker tries to show content of a folder "Test".

github-actions[bot] commented 4 months ago

Hi there @mjpraxis!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

iOvergaard commented 4 months ago

Hello, @mjpraxis, and thanks for testing.

You wrote:

The Media Picker thinks the item is a Folder

This is, in fact, a valid scenario as you can add media items below other media items if you give them a collection view. The mediapicker does not have any good options to detect this and so is forced to go "into" the item when you click the title.

It goes for all elements currently in the Mediapicker as well as the Media Library:

Clicking the image = Select Clicking the title = Navigate

We want to eventually build an understanding into the Mediapicker to be able to analyze what counts as a folder and only allow to navigate to those, but for now we have to assume that anything could be a folder. That is obviously confusing!

How can we make that more obvious to the users?

mjpraxis commented 4 months ago

Hi @iOvergaard

It is just because it works perfectly in v13 :-)

I have no solution at the moment how to make it more obvious to the user. It is just very strange that a user ends in this limbo mode.

I have never (in the 15 years using Umbraco) heard or thought of having items created under a image item 😊

iOvergaard commented 4 months ago

Good to hear you had a good experience with V13, but I am also sorry to report that V13 is riddled with bugs in that area, especially if you create Folder types of your own, as there are a lot of assumptions built into the system such as the default key for the default Folder type. Currently, we don't assume anything in V14 (for better or for worse) which leads to scenarios like these. We need better UX in this area.

mjpraxis commented 4 months ago

@iOvergaard follow up - I have just tested v13 media picker. And there is a problem picking items under for example an image item that allows sub items.

I can see that you have fixed that in v14. But introduced the issue that I have registered in this issue.

enkelmedia commented 4 months ago

We have a similar issue in v13 with a custom media type, one thing that came to my mind was:

If the current media type does not allow any other media types as children (in the structure type) than it would not be possible to put something as a child and hence should not be possible to "navigate into".

Or the other way around: If a media type allow other types as children it should probably work as a "folder".

https://github.com/umbraco/Umbraco-CMS/issues/16334

umbraco / Umbraco-CMS