[V14] RTE in classic mode shouldn't hide the separator line in larger screens

Nuklon commented 5 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14

Bug summary

This is OK: Now you can see where you can start editing.

With a large window size this line is missing:

Specifics

No response

Steps to reproduce

Use RTE in classic mode.

Expected result / actual result

No response

github-actions[bot] commented 5 months ago

Hi there @Nuklon!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

Zeegaan commented 5 months ago

I can reproduce this 😁 even on smaller screen, the bottom line is still missing 😢

iOvergaard commented 5 months ago

@Zeegaan The box-shadow is being hidden, but I fixed that with https://github.com/umbraco/Umbraco.CMS.Backoffice/pull/1979

@Nuklon Thanks for testing. TinyMCE is responsive and in my tests, I was able to set a max width in the data type configuration to prevent TinyMce from stretching its toolbar into one line. Would you verify that?

Nuklon commented 5 months ago

@Nuklon Thanks for testing. TinyMCE is responsive and in my tests, I was able to set a max width in the data type configuration to prevent TinyMce from stretching its toolbar into one line. Would you verify that?

I cannot verify this workaround unfortunately; I went back to v13 for the time being as v14 has too many bugs to be usuable. Your screenshot in the PR looks like it fixes the problem. I am wondering how it looks on small window sizes? In my first screenshot on very small window sizes there was a line added, is that still visible?

iOvergaard commented 5 months ago

@Nuklon Yes, the line appears if you make the screen smaller, but it also depends on how many items you have in the toolbar of course.

umbraco / Umbraco-CMS