umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.36k stars 2.64k forks source link

Umbraco 14 - Label fields get overwritten on save and publish #16615

Open jovanzlatanovic opened 1 week ago

jovanzlatanovic commented 1 week ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0

Bug summary

When saving and publishing a page, in the ContentSavingNotification the edited value of a label field is null.

Specifics

While debugging, inspecting values of entities shows: image

The value is not supposed to be changed since it's a "read-only" label value visible to a CMS user. The CMS user has no ability to change the value.

public void Handle(ContentSavingNotification notification)
{
        foreach (var entity in notification.SavedEntities)
        {
              entity.GetDirtyProperties() // contains labels as dirty properties
              ...
        }
}

Steps to reproduce

Save and publish a page which contains label fields.

Expected result / actual result

Expecting that the label values be unchanged.

Actual result is that they are changed and are changed to null.

github-actions[bot] commented 1 week ago

Hi there @jovanzlatanovic!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: