umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.36k stars 2.64k forks source link

V13 Unable to click the user profile in tours introduction #16619

Open SarojShresthaa opened 1 week ago

SarojShresthaa commented 1 week ago

Prerequisites

If there's an existing issue for this PR then this fixes

Description

Commented out the line / focusLockService.addInertAttribute();/ in the umbtourstep.directive.js file.

github-actions[bot] commented 1 week ago

Hi there @SarojShresthaa, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

lauraneto commented 1 week ago

Hi @SarojShresthaa ,

Thank you for your (first 🎉) pull request! 🙌 Next time please fill in the description of the pull request, especially with a reference to the ticket you are fixing, so we know what the initial issue was and how to test the changes. (this time I was able to find it and link it)

As for the pull request itself, a member of the Core Collaborators team will look into it soon! In the meantime, it would be nice if you could already check if the failing build is due to your changes, as it is failing on integration tests relating to Tours. If you follow the trail of the build, you will end up here. If you are unsure, that is no issue, let us know and we can help you out! 🙂

SarojShresthaa commented 1 week ago

Hey @lauraneto, I don't think my Changes have made those build error