umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.36k stars 2.64k forks source link

fix: uploaded item not selected in media picker #16644

Open ealse opened 1 week ago

ealse commented 1 week ago

Prerequisites

Description

Since the merge of issue #15115, uploaded items are not selected anymore.

Steps to test:

With the option "Pick multiple items" no item is selected, but this functionality did not do this before the bug was introduced either. That is why no change has been made to this behaviour.

Extra remark: issue #15115 does not appear to have resolved the problem either. I can still produce the bug.

github-actions[bot] commented 1 week ago

Hi there @ealse, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

georgebid commented 1 week ago

Hey @ealse, thanks a lot for your PR, I am sorry to see that the previous fix has caused you issues. Someone on the core collaborators team will review this soon! 😄