umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.36k stars 2.64k forks source link

[v14] Block level validation UI missing #16656

Open PerplexDaniel opened 3 days ago

PerplexDaniel commented 3 days ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0

Bug summary

In Block List / Block Grid there is no block level validation UI. If any of the blocks are invalid only the parent property itself (Block List / Block Grid) will be marked as invalid but you have no idea which block is invalid so this is not very user friendly. In addition, required properties are not marked with an asterisk (*) like in the past, and when you open each block the field that is invalid is not marked at all so you still have no idea what is wrong.

image image image

We are currently looking into migrating our custom block editor (Perplex.ContentBlocks) to v14 and it seems there is actually code for block level validation. You can pass in a dataPath to <umb-property-type-based-property> which seems to work somewhat although the error message does not work properly and just shows #validation_invalidEmpty.

image

Specifics

No response

Steps to reproduce

  1. Create an Element Type with at least 1 mandatory property
  2. Create a Block List datatype that uses the element type from step 1
  3. Add this Block List as a property on one of your regular doctypes
  4. Create some blocks without entering any data
  5. Save and Publish
  6. Observe a result similar to this:

image

When opening a block the invalid properties are not marked either so you really have no idea how to fix it and what to fix.

Expected result / actual result

No response

github-actions[bot] commented 3 days ago

Hi there @PerplexDaniel!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: