[BUG]: Confusing label "Add" and pickers that keep state

[enkelmedia]

This is not a "bug" but maybe more of a communication thing.

I've noticed that many of the pickers (Content Picker, Multi Node Tree Picker, Template Picker and more) will populate the selected state when the modal is opened.

Notice here that when I click "Add" for the 2nd time the two selected nodes are active in the tree and I can un-select them to remove them from the content picker.

I guess that this might be a good thing in some scenarios, but I also think that in many scenarios we should:

• Change the label of the dashed picker button to "Manage", "Choose" or something
• Keep the label but not pre-populate the state.

Also: Update the "Submit"-text in the modal to something more contextual.

Progress:

• [ ] Content Picker
• [ ] Multi Node Tree Picker
• [ ] Template Picker
• [ ] ....

[nielslyngsoe]

@enkelmedia interesting perspective, and well thought.

I just tested existing Backoffice pickers, and it's inconsistent how it works so now is the option to correct or a coherent experience of pickers.

I think rephrasing to "Choose" might be the right solution, cause this would keep this experience where the user are able to manage the selection in the modal. The other solution would not enable the user to adjust their selection on a later point, giving the user a weird experience of that dialog. (in other words sometimes able to select/deselect and when revisiting not.)

So with that, feel free to make a PR that rephrase these pickers to Choose instead of add. As well correct the headline and submit button of the dialogs (not sure if they jet support localizations)

[enkelmedia]

@nielslyngsoe while working on a RP for this https://github.com/umbraco/Umbraco.CMS.Backoffice/pull/1084 is also noticed that there was hardcoded "terms" that should be replaced for translations, I basically have two questions:

1. Would you prefer a small changes like this to be included in "the same" PR as the re-naming of the buttons - or do you think it requires it's own PR?
2. If I need to add new translations (i..g. "Remove document X" was not in the translations files (us-us.ts), if there any "standard" or process that I should follow? Also if I need to add it to the Danish translations as well?

[github-actions[bot]]

Hi there @enkelmedia!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: