[BUG]: Include types for TinyMCE

[enkelmedia]

When building a tinyMcePlugin the editor complains about the return type:

So I figured I'll provide strongly typed objects but it seems like the types are not included in the @umbraco-cms/backoffice package?

Is this by intension and what would be the right workaround?

[enkelmedia]

Hmm,

Looks like TinyMCE is using this internally as some kind of "bridge" https://www.npmjs.com/package/@ephox/bridge

After

npm i -D @ephox/bridge

I can do:

import { UmbLocalizationController } from '@umbraco-cms/backoffice/localization-api';
import { TinyMcePluginArguments, UmbTinyMcePluginBase } from '@umbraco-cms/backoffice/tiny-mce';
import { MYMCE_TOOLBARITEM_ALIAS } from './manifest';
import type { NestedMenuItemContents } from '@ephox/bridge/lib/main/ts/ephox/bridge/api/Menu';

export default class MyMceEditorPlugin extends UmbTinyMcePluginBase {
    constructor(args: TinyMcePluginArguments) {
        super(args);

        const localize = new UmbLocalizationController(args.host);

        this.editor.ui.registry.addMenuButton(MYMCE_TOOLBARITEM_ALIAS, {
            text: 'Fields',

            fetch: (callback) => {

                let arrMenuItems :NestedMenuItemContents[] = [
                    {
                        type: 'nestedmenuitem',
                        text: localize.term('buttons_somethingElse'),
                        getSubmenuItems: ()=> [
                            {
                                type : 'menuitem',
                                text: 'Nested Option 1',
                                onAction: () => {
                                    this.editor.insertContent('Testing');
                                }
                            }
                        ]
                    }
                ];

                callback(arrMenuItems);
            }

        });
    }
}

I guess that it's not needed to include all of this in the cms-package, but maybe provide a note in the documentation.

Feel free to close this issue or keep it for reference until docs are updated.

[github-actions[bot]]

Hi there @enkelmedia!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: