umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.42k stars 2.66k forks source link

[BUG]: Modal Route does not support navigation with browser history #16684

Open enkelmedia opened 5 months ago

enkelmedia commented 5 months ago

I just notice that the behavior of the routed modal (UmbModalRouteRegistrationController) is quite strange when clicking on the "back"-button in the browser.

The route changes in the address bar and the view "behind" the modal is changing - but the modal is still on top of everything.

umb-modal-strange

In an ideal world there should be some kind of callback, like the onSetup(), onReject() to hook into the navigation and maybe prompt the user if "the thing" in the modal is not saved.

I played with some of the events from the router-slot library but the route still changed.

window.addEventListener("willchangestate", e => {

    // Check if we should navigate away from this page
    if (!confirm("You have unsaved data. Do you wish to discard it?")) {
        e.preventDefault();
        return;
    }

}, {once: true});
github-actions[bot] commented 2 months ago

Hi there @enkelmedia!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: