umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

[BUG]: Overwriting a workspace action removes popover menu items #16700

Open warrenbuckley opened 4 months ago

warrenbuckley commented 4 months ago

Describe the bug I expect to overwrite just a single Workspace Action without having to copy & reimplement all the child menu workspace actions.

To Reproduce Steps to reproduce the behavior:

import { UMB_ENTITY_IS_NOT_TRASHED_CONDITION_ALIAS } from '@umbraco-cms/backoffice/recycle-bin';
import type { ManifestWorkspaceActions } from '@umbraco-cms/backoffice/extension-registry';

export const manifests: Array<ManifestWorkspaceActions> = [
{
        type: 'workspaceAction',
        kind: 'default',
        overwrites: 'Umb.WorkspaceAction.Document.SaveAndPublish', // Alias of thing you wanna overwrite
        alias: 'Custom.WorkspaceAction.Document.SaveAndPublish',
        name: '[Custom] Save And Publish Document Workspace Action',
        api: () => import('./custom.save-and-publish.action.js'),
        weight: 70,
        meta: {
            look: 'primary',
            color: 'positive',
            label: 'My custom Save & Publish',
        },
        conditions: [
            {
                alias: 'Umb.Condition.WorkspaceAlias',
                match: 'Umb.Workspace.Document',  // Cant get UMB_DOCUMENT_WORKSPACE_ALIAS const
            },
            {
                alias: UMB_ENTITY_IS_NOT_TRASHED_CONDITION_ALIAS,
            },
        ]
    },  
];

Expected behavior I expect to overwrite just a single Workspace Action without having to copy & reimplement all the child menu workspace actions.

Screenshots image

Desktop (please complete the following information):

github-actions[bot] commented 4 months ago

Hi there @warrenbuckley!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: