Umbraco 14 - config/lang/en_us.users.xml no longer displays custom login messages

jovanzlatanovic commented 5 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0

Bug summary

config/lang xml files no longer customize the login message.

Specifics

After creating the config/lang xml file as specified here: https://docs.umbraco.com/umbraco-cms/fundamentals/backoffice/login#greeting

the "Welcome" text does not change on the login screen.

Steps to reproduce

Setup custom messages for login screen.

Expected result / actual result

Expected to see custom login message, actually don't see it.

github-actions[bot] commented 5 months ago

Hi there @jovanzlatanovic!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

iOvergaard commented 5 months ago

Hi there Have a look here at how to do UI localizations for V14: https://docs.umbraco.com/umbraco-cms/extending/language-files/ui-localization

The keys should be the same, e.g. login:greeting1.

Let us know if it works 👍

jovanzlatanovic commented 5 months ago

Hi @iOvergaard, thanks for the help but I can't seem to get it to work:

I've tried both the external js file and the meta tags one (did try "translations" instead of "localizations" as well):

I did notice that the localization section and key should be correct as well in the source code for the login page: https://github.com/umbraco/Umbraco-CMS/blob/3ce2e97f5e13de0f4e69ff8943c66744d3103b27/src/Umbraco.Web.UI.Login/src/components/pages/login.page.element.ts#L111

Checking the installed packages, the package is added to the backoffice:

I'm not really sure what I'm doing wrong in my setup?

iOvergaard commented 5 months ago

@jovanzlatanovic There might be a mismatch on our side. Technically there are two login screens: One for local login and one to select a login provider. In the first screenshot, you seem to be using the latter. On that screen, the keys happen to be prefixed with "login" and not "auth".

Could you try with:

"login": {
  "greeting0": "AAA",
  ...etc...
}

It is unfortunate, but you probably have to specify both namespaces at the moment.

jovanzlatanovic commented 5 months ago

@iOvergaard not having luck with this one either 😅

jovanzlatanovic commented 5 months ago

Just an extra side note, the local login screen doesn't appear take the greeting text either:

It's almost as if the translation values aren't being read.

iOvergaard commented 5 months ago

@jovanzlatanovic Could you try and add "allowPublicAccess": true in between your "name" and "extensions" properties, please?

jovanzlatanovic commented 5 months ago

@iOvergaard thanks that did it!

The login provider selection screen works fine now, but on the "local" login screen it seems a bit wonky where upon first load it loads "Welcome" and refreshing the page then brings the custom message.

I can reproduce it multiple times by opening a fresh incognito browser then clicking "Sign in with Umbraco" where I'm greeted with "Welcome" the first time, upon refreshing the page the custom message pops up.

iOvergaard commented 5 months ago

@iOvergaard thanks that did it!

The login provider selection screen works fine now, but on the "local" login screen it seems a bit wonky where upon first load it loads "Welcome" and refreshing the page then brings the custom message.

I can reproduce it multiple times by opening a fresh incognito browser then clicking "Sign in with Umbraco" where I'm greeted with "Welcome" the first time, upon refreshing the page the custom message pops up.

That sounds like something we should address. I'll create a new issue based on your description here!

umbraco / Umbraco-CMS