search

umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.37k stars 2.64k forks source link

V14: Umbraco.Web.UI.Login localizations do not work on first load #16730

Open iOvergaard opened 2 weeks ago

iOvergaard commented 2 weeks ago

The login provider selection screen works fine now, but on the "local" login screen it seems a bit wonky where upon first load it loads "Welcome" and refreshing the page then brings the custom message.

I can reproduce it multiple times by opening a fresh incognito browser then clicking "Sign in with Umbraco" where I'm greeted with "Welcome" the first time, upon refreshing the page the custom message pops up.

Originally posted by @jovanzlatanovic in https://github.com/umbraco/Umbraco-CMS/issues/16726#issuecomment-2205708323

iOvergaard commented 2 weeks ago

Also to note, that the Umbraco.Web.UI.Login project uses the "auth" namespace and the Umbraco.Web.UI.Client provider selection screen uses the "login" namespace for localizations. We might want to align those. "Login" was the original namespace for login translations.