mattbrailsford
commented
1 week ago In order to just be able to define my variants property editor, so far I have had to copy the following files into my solution
- https://github.com/umbraco/Umbraco-CMS/blob/v14/dev/src/Umbraco.Infrastructure/PropertyEditors/BlockEditorPropertyValueEditor.cs
- https://github.com/umbraco/Umbraco-CMS/blob/v14/dev/src/Umbraco.Infrastructure/PropertyEditors/BlockEditorValidator.cs
- https://github.com/umbraco/Umbraco-CMS/blob/v14/dev/src/Umbraco.Infrastructure/PropertyEditors/BlockEditorValidatorBase.cs
- https://github.com/umbraco/Umbraco-CMS/blob/v14/dev/src/Umbraco.Infrastructure/PropertyEditors/BlockEditorValues.cs
- https://github.com/umbraco/Umbraco-CMS/blob/v14/dev/src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
v14
Bug summary
Back in 2021 it was highlighted that the block list had been too tightly coupled to the core implementation in the following issue https://github.com/umbraco/Umbraco-CMS/issues/9781. The intention behind the block list is that it should be extendable by others.
Is highlighted in the 2021 issue I showed the hacky workaround that was needed to make it work for Vendr (and this continues to be the case in Umbraco Commerce).
In v14 however, something else has changed and the hack no longer works. As such, I'm requesting this is looked at and resovled. I believe currently that the main issue is that the block based property editor base classes are all internal and so there is no way to derive your own block editor type that doesn't strictly adhere to the block list models.
Specifics
See summary
Steps to reproduce
Try and create a property editor that extends the grid structures.
Expected result / actual result
We should be able to create our own property editors based on blocks and be able to use the property editor base classes to save a lot of shared logic.