umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.39k stars 2.65k forks source link

Wrong LastLockOut DateTime value #16761

Open KudAndrii opened 1 month ago

KudAndrii commented 1 month ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.3.0

Bug summary

IMembershipUser.LastLockoutDate is set as DateTime, value is equal to the server offset time but kind of it equal to UTC

Specifics

No response

Steps to reproduce

enter wrong password needed amount of times to be locked out, and you will be locked out till the DateTime which will be calculated as the following: IMembershipUser.LastLockoutDate + MemberDefaultLockoutTimeInMinutes but as far as IMembershipUser.LastLockoutDate is set incorrectly any minutes you specify in the MemberDefaultLockoutTimeInMinutes will be added to your server offset

Expected result / actual result

Expected result: be locked out for MemberDefaultLockoutTimeInMinutes. Actual result: locked out for MemberDefaultLockoutTimeInMinutes + server offset

github-actions[bot] commented 1 month ago

Hi there @KudAndrii!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

rbottema commented 1 month ago

This is probably related to #16125, as it affects all DateTimes stored in the database.