umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.4k stars 2.66k forks source link

URL Picker styling breaks when inline RTE is on same document type #16778

Open rbottema opened 1 month ago

rbottema commented 1 month ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.4

Bug summary

We have noticed that whenever an inline RTE is on a document type, some of the stylesheet applied to it 'leaks out'. This is at least visible in the URL picker, where the 'Link to page' and 'Link to media' texts take over the h5 styling of the stylesheet.

image

Specifics

No response

Steps to reproduce

Expected result / actual result

No response

github-actions[bot] commented 1 month ago

Hi there @rbottema!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

elit0451 commented 1 month ago

Hi @rbottema 👋

Thanks for reaching out! I, unfortunately, couldn't reproduce this in v13.4.1:

https://github.com/user-attachments/assets/01d6e7f7-94a5-4e9b-b180-02ba8d287bc3

Have a look and see if I am missing something.

Also, I noticed that we need to place "RichTextEditor" block inside "Umbraco"::"CMS" in appsettings as pointed out here and not in just "Umbraco" as you initially thought, but unfortunately, that didn't make a difference and things worked as expected.

rbottema commented 1 month ago

Hi @elit0451, thanks for trying to replicate! I'll check later to see if I missed anything in my reproduction steps.

On the video I do see that you are styling on .h5 (i.e: a class named h5) instead of h5 (i.e: the h5 HTML tag). Could that explain the difference?

elit0451 commented 1 month ago

YES, that was it 🙌

I was able to reproduce it and here is a video of my reproduction steps:

https://github.com/user-attachments/assets/e2e831d2-19f1-4ad2-adac-134ea7053395

We would like some help fixing this, so I will mark it as up for grabs 🙂

github-actions[bot] commented 1 month ago

Hi @rbottema,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)