Embeds in RTE are not included

jemayn commented 3 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.4.1

Bug summary

When I add an embed in an RTE it removes it on save. I've found this issue which seems related but mentions it only being an issue specifically in an RTE in a grid: https://github.com/umbraco/Umbraco-CMS/issues/11755

It sometimes allows me to add the embed, then afterwards if I try to edit the width/height of the included embed it doesn't save that change either.

Specifics

Initially found the issue on 13.3.2, tested on latest 13.4.1 and could reproduce (see below)

Steps to reproduce

I've reproduced this on a fresh site:

Create site, here is the PSW I used
Add a new RTE with default settings to a doc type directly (not in any nested editor)
Try to add an embedded link and save, I tested with https://www.youtube.com/watch?v=4BcTNW9LDws

Here is what happened:

https://github.com/user-attachments/assets/bbab57f6-283d-424a-b4ed-fb975c311669

Expected result / actual result

Expect it to save the embed properly, and also update it when I try to change it.

This item has been added to our backlog AB#43610

github-actions[bot] commented 3 months ago

Hi there @jemayn!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

elit0451 commented 2 months ago

Hey @jemayn 👋

It is nice to hear from you! Thanks for reaching out. 🙂 I am able to reproduce the issue, and it seems like adding text before it makes it stay:

https://github.com/user-attachments/assets/e9caf6e2-4277-4c3d-ab52-5fd4e934fdbe

We would love some help fixing this 🙌 so I will mark it as up for grabs. Meanwhile, there is the workaround.

github-actions[bot] commented 2 months ago

Hi @jemayn,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

github-actions[bot] commented 3 weeks ago

Hi @jemayn,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

iOvergaard commented 3 weeks ago

This should have been fixed in V14+. I am not sure if there is an easy fix in older Umbraco versions, but if anyone is willing to confirm that it works or is still a problem, feel free to do so!

jemayn commented 5 days ago

Hey @iOvergaard

I can no longer reproduce my original issue on 13.5.2. Seems like https://github.com/umbraco/Umbraco-CMS/pull/17008 has fixed it 🙂

Thanks to the team!

I am closing this issue.

umbraco / Umbraco-CMS