umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.41k stars 2.66k forks source link

MultiNodeTreePicker Macro Parameter EDIT not working properly inside RTE #16814

Open jpinto3488 opened 1 month ago

jpinto3488 commented 1 month ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.4.0

Bug summary

Macro with parameter of type MultiNodeTreePicker, if it has already picked elements, when trying to add new ones, it won't keep the change. If the macro parameters button is clicked again after the change, but before saving, it will work instead.

Here's a video displaying the issue and the "workaround" of clicking the parameters button again:

https://github.com/user-attachments/assets/727d9fa0-2a87-43bc-beb2-e922ff9937e9

Specifics

No response

Steps to reproduce

Not working: 1 - Create a macro with a MultiNodeTreePicker parameter. 2 - Add the macro to an RTE 3 - Pick some nodes with MultiNodeTreePicker 4 - Save & Publish 5 - Refresh the page 6 - Select the macro within the RTE 7 - Click on "settings" button of the RTE to review the macro parameters 8 - Add another node to the MultiNodeTreePicker 9 - Hit the 2 submit buttons, then save & publish 10 - Refresh the page 11 - Select the macro within the RTE 12 - Click on "settings" button of the RTE to review the macro parameters 13 - The node(s) added on step 8 are not present.

Working Workaround: 1 - Create a macro with a MultiNodeTreePicker parameter. 2 - Add the macro to an RTE 3 - Pick some nodes with MultiNodeTreePicker 4 - Save & Publish 5 - Refresh the page 6 - Select the macro within the RTE 7 - Click on "settings" button of the RTE to review the macro parameters 8 - Add another node to the MultiNodeTreePicker 9 - Hit the 2 submit buttons 10 - Click on "settings" button of the RTE to review the macro parameters 11 - Hit the submit button, then save & publish 12 - Refresh the page 13 - Select the macro within the RTE 14 - Click on "settings" button of the RTE to review the macro parameters 15 - The node(s) added on step 8 are present.

Expected result / actual result

No response

EDIT:

It happens also with Umbraco.MultipleMediaPicker It may be related to this issue: https://github.com/umbraco/Umbraco-CMS/issues/16212

Seems that only Chromium browsers are affected

github-actions[bot] commented 1 month ago

Hi there @jpinto3488!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: