Partial view depth 2 Throws API Error - Not found

lars-lindstrom commented 3 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.2.0--rc.preview.9.g7e444e5

Bug summary

The problem is not isolated to version 14.2.0--rc.preview.9.g7e444e5, it also happend in v 14.0.0, 14.1.0 and 14.1.1

The problem locks similar to this bug in Umbraco Cloud https://github.com/umbraco/Umbraco.Cloud.Issues/issues/806

Specifics

The bug occurs on calls to the "/umbraco/management/api/v1/partial-view/{path}" endpoint

Steps to reproduce

Opening any file at a depth of 2 or more in the partials folder results in an "API Error" 404.

The underlying call to the Management API returns a 404

If a file is placed in the "Partials" folder depth 1, no error is produced

Expected result / actual result

The selected file at depth 2 or more should be loaded for editing in the BackOffice

github-actions[bot] commented 3 months ago

Hi there @lars-lindstrom!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

elit0451 commented 3 months ago

Hi @lars-lindstrom 👋

Thanks for reaching out! Unfortunately, I wasn't able to reproduce this in Umbraco 14.1.1. Here is a video of what I did, perhaps you can point me to what I'm missing:

https://github.com/user-attachments/assets/4695a033-bcf7-4664-bea3-9d5853ca342f

Nicole-Buys commented 2 months ago

I have also run into this issue still. CMS v14.1.2

Steps to reproduce: I have only been able to reproduce this error on Umbraco Cloud as it does not seem to happen locally.

create a fresh v14 project on cloud
go to partial views --> blockgrid
try to view or create any partial views

The error in the console refers to an authentication token that is missing

matthew-covey-el commented 2 months ago

We are experience the exact issue that Nicole describes above on Umbraco Cloud. CMS v14.2.0

j9850s commented 1 month ago

This is a host problem. For example Azure rewrites the "%2F" to "/" https://learn.microsoft.com/en-us/answers/questions/2007707/azure-app-services-decodes-2f-in-a-inbound-request https://learn.microsoft.com/nl-nl/aspnet/core/fundamentals/routing?view=aspnetcore-7.0#routing-with-special-characters

For fixing this you can add middleware to rewrite the original url. https://github.com/LogOtter/log-otter/pull/188

If the Umbraco team is eager for fixing this in Umbraco. is a possible fix to Base64 the path variable and decode it back in the controller.

repo: deploy umbraco to azure See API results without authentication: {site}/umbraco/management/api/v1/partial-view/%2FName.cshtml - 401 unauthourized as expected {site}/umbraco/management/api/v1/partial-view/%2Fblockgrid%2Fdefault.cshtml - 404 not found, This is not expected

j9850s commented 1 month ago

https://github.com/umbraco/Umbraco.Cloud.Issues/issues/806#issuecomment-2404515470

umbraco / Umbraco-CMS