RTE expands infinitely when not on the initial view

MarkMcDonald commented 3 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.4.1

Bug summary

I have just upgrade from Umbraco 11 to 13.4.1. In the backoffice now if I have a RTE on a idfferent tab to the default, or move from Child Items -> Content and it has a RTE on, the RTE starts expanding down the screen.

Specifics

It does this on any page where there is a RTE not on the default view, i.e. having to tab through.

It does this regardless of if there is any content populated or not.

Steps to reproduce

https://github.com/user-attachments/assets/eea89910-d45b-4fbb-895e-f6a8ec121e8b

Expected result / actual result

It doesn't scroll when it doesn't need to expand to fit the content.

github-actions[bot] commented 3 months ago

Hi there @MarkMcDonald!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

MarkMcDonald commented 3 months ago

I have managed to determine this is something to do with the custom styles applied to the editor (bootstrap based), possibly interacting with the TinyMCE autoresize which I presume is used, but not exactly what.

Why it only occurs in secondary tabs I don't know. It is a shame as it wasn't previously an issue in Umbraco 11, but I assume it is more an upgraded TinyMCE issue that Umbraco one.

MarkMcDonald commented 3 months ago

Issue seems to be caused by the having the following style rule in the stylesheet used for TinyMCE

html { min-height: 100%; }

I think there may be a race condition in TinyMCE with the autoresize functionality and the data-mce-style attribute which then looks to set min-height: 0px

Best guess is that it only applies when switching tab as autoresize may normally wait for some page loading event, which would have all already fired when changing tabs.

elit0451 commented 2 months ago

Hi @MarkMcDonald 👋

Thanks for reaching out! Unfortunately, I wasn't able to reproduce this on Umbraco 13.4.1. Can you see the video below and let me know if I am missing something?

https://github.com/user-attachments/assets/4b5010a0-0e62-4dbb-8eae-02ab00c758b2

umbraco / Umbraco-CMS