umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.41k stars 2.66k forks source link

[v14] Remove pink as a selectable icon color for document icons #16882

Open mattbrailsford opened 1 month ago

mattbrailsford commented 1 month ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v14

Bug summary

It is currently possible to select pink for the icon color of a document type icon, however this is the color of the highlight when a content tree item is selected. As such, when highlighted the icon disappears.

If pink is the color for the highlight, we should prevent people from using it as an icon color.

Specifics

image

Steps to reproduce

Expected result / actual result

No response

bjarnef commented 1 month ago

I think in pre v14 the icon of a highlighted tree node was always a specific color, black IIRC.

nathanwoulfe commented 1 month ago

I think @bjarnef is correct - icon color should match the text color in a selected menu item. Pretty sure that's how it was previously.

bjarnef commented 1 month ago

In v13 it looks like this:

image

Some of the colors may not work in icon picker, e.g. light yellow and pink due the contrast on white background. Previous the pink was darker, but was changed to a brighter color to avoid look to much as an error.