Changing the order in the repeatable strings isn't saved

mdeslauriers-sigmund commented 1 month ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.1.1

Bug summary

In the property-editor "Multiple reapeatable strings" when you change the order of existing entries, no change event is dispatched and the changes aren't saved.

Specifics

The problem occurs in Umbraco.CMS.Backoffice\src\packages\core\components\multiple-text-string-input\input-multiple-text-string.element.ts

In the configuration of the #sorter there is the following code :

#sorter = new UmbSorterController(this, {
    getUniqueOfElement: (element) => {
        return element.getAttribute('data-sort-entry-id');
    },
    getUniqueOfModel: (modelEntry: string) => {
        return modelEntry;
    },
    identifier: 'Umb.SorterIdentifier.ColorEditor',
    itemSelector: 'umb-input-multiple-text-string-item',
    containerSelector: '#sorter-wrapper',
    onChange: ({ model }) => {
        const oldValue = this._items;
        this._items = model;
        this.requestUpdate('_items', oldValue);
    },
});

There should be a call to this.dispatchEvent(new UmbChangeEvent()); at the end of the onChange method to notify the parent property-editor that there is a new sort order. (dispatchEvent is called for all other changes in the component)

Btw, the identifier could be renamed to something like 'Umb.SorterIdentifier.InputMultipleTextString', it seems like a copy/paste from another file (multiple-color-picker-input.element.ts).

Steps to reproduce

Create a property using "Multiple reapeatable strings" in a document type
Create a document with this document type
Add 3 strings in the property
Save the document.
Fully reload the browser-page to ensure it is fresh
Change the order of the strings (do not modify the entries text, only change the sort-order)
Click save
Fully reload the browser-page again

Result : the change wasn't saved

Expected result / actual result

Changing the order and saving should be persisted, event if no strings are modified

github-actions[bot] commented 1 month ago

Hi there @mdeslauriers-sigmund!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

NguyenThuyLan commented 20 hours ago

Thank @mdeslauriers-sigmund for reporting this issue. I can reproduce this on 14.3.0

ccasalicchio commented 6 hours ago

This issue does occur in 13.4.1

umbraco / Umbraco-CMS