umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

V13.5-RC Content fields to stay disabled when save and publishing #17019

Closed Yinzy00 closed 2 months ago

Yinzy00 commented 2 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v13.5.0 RC

Bug summary

We discovered that when attempting to save and publish with invalid fields, those fields remained disabled.

We tested this with text fields, media pickers, block lists

Specifics

No response

Steps to reproduce

  1. Add a mandatory text field to a doctype
  2. Add a non mandatory text field to that doctype
  3. Create an instance of that doctype
  4. Save and publish without value => After validation text fields (and blocklist, mediapicker, ...) will stay disabled

Expected result / actual result

Fields should be disabled while save and publishing but should be enabled after validation.

github-actions[bot] commented 2 months ago

Hi there @Yinzy00!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

Yinzy00 commented 2 months ago

Fixed in: #17018

laimonas commented 2 months ago

I have upgraded to latest

validation

@Yinzy00 @nielslyngsoe any thoughts why this is still happening?

laimonas commented 2 months ago

Created new issue here https://github.com/umbraco/Umbraco-CMS/issues/17054 I think one difference that our page can vary by culture