umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.52k stars 2.69k forks source link

SendingContentNotification missing, still mentioned in "additional preview environments" documentation #17035

Open melslenstra-dc opened 2 months ago

melslenstra-dc commented 2 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.2.0

Bug summary

It looks like PR #15855 removed the SendingContentNotification type, which is still mentioned in v14 docs as the way to hook in and add preview environments - a pretty critical feature when looking to use Umbraco as headless CMS with the Delivery API.

Documentation: https://docs.umbraco.com/umbraco-cms/reference/content-delivery-api/additional-preview-environments-support

Specifics

No response

Steps to reproduce

Copy the example from aforementioned document into your codebase, observe the type SendingContentNotification is nowhere to be found.

After some investigation, the deletion of said type traces back to commit 69a691f315daba382545ffd677886b940bb00acb which got merged in PR #15855 .

Expected result / actual result

To be able to follow documentation and successfully add custom preview environment URL(s) to the Umbraco backoffice in v14(+)

github-actions[bot] commented 2 months ago

Hi there @melslenstra-dc!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

reinhard-seidl-mw commented 1 month ago

Is someone looking into this?

wicketbr commented 1 month ago

I need this as well. The documentation page (https://docs.umbraco.com/umbraco-cms/reference/notifications/editormodel-notifications) mentions this has been moved from the server-side to client-side, but there is no further information or code example.

DanielToft commented 2 days ago

What is the status of this task?

https://github.com/umbraco/Umbraco-CMS/blob/bff321e6f5999e162210a8d36cf077ce54998966/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save-and-preview.action.ts#L7