[BUG] V13.5.0 Content fields to stay disabled when save and publishing

laimonas commented 1 month ago

Which Umbraco version are you using?

13.5.0

Bug summary

validation

We discovered that when attempting to save and publish with invalid fields, those fields remained disabled. The same as closed issue, maybe one difference that our page can vary by culture https://github.com/umbraco/Umbraco-CMS/issues/17019

Specifics

No response

Steps to reproduce

Add a mandatory text field to a doctype Add a non mandatory text field to that doctype Create an instance of that doctype Save and publish without value => After validation text fields (and blocklist, mediapicker, ...) will stay disabled

Expected result / actual result

No response

github-actions[bot] commented 1 month ago

Hi there @laimonas!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

laimonas commented 1 month ago

I have look into last fixed introduced int 13.5.0 RC https://github.com/umbraco/Umbraco-CMS/pull/17018/files#diff-e0285787f867b6af6e7475492117224e187b2d4297af96f98fcba2b9f5cfff10

In my case i'm hitting this place And i think after showValidationNotification(); $scope.$broadcast("formSubmittedValidationFailed") is missing.

laimonas commented 1 month ago

I Also tried with fresh 13.5.0 install. Steps to reproduce.

Create document type with required field
Eanable "Allow vary by culture" on this document type
Create one any additional language
"Save and Publish"

I cannot reproduce this on previous 13.4.1 version. I think this is really critical bug left with this release.

nielslyngsoe commented 1 month ago

Fixed by https://github.com/umbraco/Umbraco-CMS/pull/17077

DempseySbaiz commented 4 weeks ago

I still have this exact issue after upgrading to 13.5.1.

Wolfkhan66 commented 3 weeks ago

We still have this same issue on 13.5.1.

laimonas commented 3 weeks ago

@DempseySbaiz @Wolfkhan66 Keep in mind i registered this bug for document types that vary by culture, and for me this fix is working. But prob with this fix they introduce bug for document that doesn't vary by culture. https://github.com/umbraco/Umbraco-CMS/issues/17187

Wolfkhan66 commented 3 weeks ago

Ah sorry, yes we have this issue for content that does not vary by culture.

umbraco / Umbraco-CMS