UmbracoContext.PublishedRequest is null, using UmbracoPageController

[merijng]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.3.0

Bug summary

IUmbracoContextFactory in Umbraco is not functioning as expected in Umbraco versions 14.3.0 and 13.x.x. PublishedRequest is null. This issue does not occur in Umbraco version 12.3.10.

Specifics

• Affected versions: Umbraco 13.x.x and Umbraco 14.3.0
• Working version: Umbraco 12.3.10
• Environment: IUmbracoContextFactory to access PublishedRequest in UmbracoPageController.

Steps to reproduce

Install Umbraco 12.3.10 using:

   dotnet new install Umbraco.Templates::12.3.10
   dotnet new umbraco -n MyProject

• Run the application and add a controller similar to TestController (as below) using the UmbracoPageController and the FindContent method.
• Also register the controller (as below) to WithEndpoints, within Startup.cs.
• Run the application and access the /test/{id} URL.
• The test should pass as expected.

Install Umbraco 14.3.0 following the Umbraco documentation.

• Add the same TestController implementation. Add the endpoint in Program.cs
• Run the application and access the /test/{id} URL.
• The test will fail with a null PublishedRequest.

using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.Filters;
using Microsoft.AspNetCore.Mvc.ViewEngines;
using Umbraco.Cms.Core.Models.PublishedContent;
using Umbraco.Cms.Core.Web;
using Umbraco.Cms.Web.Common.Controllers;

public class TestController : UmbracoPageController, IVirtualPageController
{
    private readonly IUmbracoContextFactory _umbracoContextFactory;

    public TestController(
        ILogger<UmbracoPageController> logger,
        ICompositeViewEngine compositeViewEngine,
        IUmbracoContextFactory umbracoContextFactory)
        : base(logger, compositeViewEngine)
    {
        _umbracoContextFactory = umbracoContextFactory;
    }

    public IPublishedContent FindContent(ActionExecutingContext actionExecutingContext)
    {
        using (var reference = _umbracoContextFactory.EnsureUmbracoContext())
        {
            if (reference.UmbracoContext.PublishedRequest == null)
                throw new Exception("Test failed");
            else
                throw new Exception("Test passed");
        }
    }

    [HttpGet]
    public async Task<IActionResult> Index(string id = null)
    {
        throw new Exception("Test passed");
    }
}

u.EndpointRouteBuilder.MapControllerRoute(
   nameof(TestController),
   "/test/{id?}",
   new { Controller = "Test", Action = "Index" });

Expected result / actual result

• PublishedRequest not being null.

[github-actions[bot]]

Hi there @merijng!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

[merijng]

Maybe related to #16426 and/or #12834?