umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.44k stars 2.67k forks source link

[15.0.0-rc1] Entity action opening modal is broken #17242

Open skttl opened 2 hours ago

skttl commented 2 hours ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0-rc1

Bug summary

I have this entity action

import { UmbControllerHostElement } from "@umbraco-cms/backoffice/controller-api";
import { UmbEntityActionArgs, UmbEntityActionBase } from "@umbraco-cms/backoffice/entity-action";
import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
import { REINDEX_NODE_MODAL_TOKEN } from "../../modals/reindexnode.modaltoken";

export class ReindexNodeAction extends UmbEntityActionBase<never> {
    #modalManagerContext?: typeof UMB_MODAL_MANAGER_CONTEXT.TYPE;

    constructor(host: UmbControllerHostElement, args: UmbEntityActionArgs<never>) {
        super(host, args)

        this.consumeContext(UMB_MODAL_MANAGER_CONTEXT, (instance) => {
            this.#modalManagerContext = instance;
        });
    }

    async execute() {
        this.#modalManagerContext?.open(this, REINDEX_NODE_MODAL_TOKEN, {
            data: {
                unique: this.args.unique
            }
        });
    }

};

export default ReindexNodeAction;

In v14 when clicking the action, the modal opens as expected - in v15 nothing happens, not even an error in the console.

I still use the entryPoint extension point though, don't know if that could be the cause. But the entity action shows up at least, so some parts of the old entryPoint still works.

Specifics

All the client code can be found here https://github.com/skttl/umbraco-fulltextsearch8/tree/v5/dev/src/Our.Umbraco.FullTextSearch.Client

Steps to reproduce

Expected result / actual result

It should have opened a modal, where you can select to reindex the single node, or the node and its descendants.

github-actions[bot] commented 2 hours ago

Hi there @skttl!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: