umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

Content picker search is broken #17343

Open StudioBravo opened 3 weeks ago

StudioBravo commented 3 weeks ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.3.1

Bug summary

The content picker search functionality seems to be searching across all content across the site rather than the restricted content for the picker.

Specifics

No response

Steps to reproduce

image

image

Expected result / actual result

The search functionality should be looking through the restricted documents rather than across the whole site.


This item has been added to our backlog AB#45280

github-actions[bot] commented 3 weeks ago

Hi there @StudioBravo!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

Zeegaan commented 3 weeks ago

I can reproduce this, looks like when we are calling the search endpoint, we are no longer accounting for the context of the content picker 😁

nikolajlauridsen commented 1 week ago

I just looked at this, and this turns out to be a frontend issue.

On 13 there was a "start from" query parameter on the tree search, which would limit the search to a specific start node. This query parameter is still there for /item/document/search just called parentId now which the frontend should use but doesn't.

Similarly, on V13 the frontend did a lookup on the datatype and used the filter property to filter out the document types that aren't allowed according to the configuration, this doesn't happen either 😄