umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.53k stars 2.71k forks source link

Publish in context menu from content tree implies it will open a dialog, but just publishes #17567

Open stevetemple opened 1 week ago

stevetemple commented 1 week ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0

Bug summary

In the UI the publish option is written as "Publish..." image

This implies to me that it's going to open a dialog as it is suffixed with the ellipsis, however it appears to just publish the page. I was expecting to see the publish with descendants dialog

See video: https://github.com/user-attachments/assets/79489b9b-9a37-48ac-82ff-7645faad3340

Specifics

No response

Steps to reproduce

Go to a page, in content tree click ... then Publish...

You should just get the page to publish, with no dialog showing

Expected result / actual result

Either it's just Publish and works as is. Or it's Publish... and the dialog appears giving options such as publish descendants.

github-actions[bot] commented 1 week ago

Hi there @stevetemple!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

NguyenThuyLan commented 8 hours ago

Hi @stevetemple , its there, because when the document has culture variants it opens a dialog where you have to choose which variants to publish, but in the non-variant case, it should not be there or have a confirm dialog for the non-variant-publishing. We will fix that, thank you for reporting the issue

stevetemple commented 8 hours ago

I'd say the most likely use case for publishing from the tree is to want to publish including descendants, how it was previously iirc. So showing the publish dialog. Publishing from the node itself you would most likely want to publish a single node.