umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.53k stars 2.7k forks source link

v15 Auditservice GetLogs return items with an default Datetime as createdate #17638

Open jbppraxis opened 2 hours ago

jbppraxis commented 2 hours ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v15.0

Bug summary

I needed to get auditlogs for a specific node. So i DI the IAuditservice and used the GetLogs() e.g. _auditService.GetLogs(rootContent.Id); however alle the items which is returned has a default createdate.

I then tried the GetPageBy... instead _auditService.GetPagedItemsByEntity(rootContent.Id, 0, 10, out var total, auditTypeFilter: [AuditType.Publish]); This call returned items witn an createdate.

I took a look into github and found that there is an explicit mapping of createdate in GetPagedResultsByQuery https://github.com/umbraco/Umbraco-CMS/blob/475faba5fd65303ab3101d4a011ca3154e649797/src/Umbraco.Infrastructure/Persistence/Repositories/Implement/AuditRepository.cs#L110 which is not in Get. https://github.com/umbraco/Umbraco-CMS/blob/475faba5fd65303ab3101d4a011ca3154e649797/src/Umbraco.Infrastructure/Persistence/Repositories/Implement/AuditRepository.cs#L22

It might be by design or it might not be related or it might be an bug :)

Specifics

No response

Steps to reproduce

Denpendency inject the auditservice and try the getlogs method and see that the createdate is default

Expected result / actual result

I would expect the createdate to have an value

github-actions[bot] commented 2 hours ago

Hi there @jbppraxis!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: