kjac
commented
5 years ago One workaround could be to create an IPublishedContent from the IPublishedElement parameter of PublishedModelFactory.CreateModel(IPublishedElement element) - something along these lines:
public IPublishedElement CreateModel(IPublishedElement element)
{
// fail fast
if (_modelInfos == null)
return element;
if (!_modelInfos.TryGetValue(element.ContentType.Alias, out var modelInfo))
return element;
// ReSharper disable once UseMethodIsInstanceOfType
if (modelInfo.ParameterType.IsAssignableFrom(element.GetType()) == false)
{
if (modelInfo.ParameterType == typeof(IPublishedContent))
{
element = new PublishedContentSomethingSomething(element);
}
else
{
throw new InvalidOperationException($"Model {modelInfo.ModelType} expects argument of type {modelInfo.ParameterType.FullName}, but got {element.GetType().FullName}.");
}
}
// can cast, because we checked when creating the ctor
return (IPublishedElement) modelInfo.Ctor(element);
}Where PublishedContentSomethingSomething is a private implementation of IPublishedContent:
private class PublishedContentSomethingSomething : IPublishedContent
{
private readonly IPublishedElement _element;
public PublishedContentSomethingSomething(IPublishedElement element)
{
_element = element;
}
public PublishedContentType ContentType => _element.ContentType;
public Guid Key => _element.Key;
public IEnumerable<IPublishedProperty> Properties => _element.Properties;
public IPublishedProperty GetProperty(string alias) => _element.GetProperty(alias);
public int Id { get; }
public string Name { get; }
public string UrlSegment { get; }
public int SortOrder { get; }
public int Level { get; }
public string Path { get; }
public int TemplateId { get; }
public int CreatorId { get; }
public string CreatorName { get; }
public DateTime CreateDate { get; }
public int WriterId { get; }
public string WriterName { get; }
public DateTime UpdateDate { get; }
public string Url { get; }
public string GetUrl(string culture = null) => null;
public PublishedCultureInfo GetCulture(string culture = null) => null;
public IReadOnlyDictionary<string, PublishedCultureInfo> Cultures { get; }
public PublishedItemType ItemType { get; }
public bool IsDraft(string culture = null) => false;
public IPublishedContent Parent { get; }
public IEnumerable<IPublishedContent> Children { get; }
}It works... but it really feels kinda ugly.
zpqrtbnk
If ModelsBuilder runs in LiveAppData mode, Nested Content breaks with this exception (see full stack trace in the end of the issue description):
This happens when
NestedContentValueConverterBasepasses anIPublishedElementtoPublishedModelFactory.CreateModel(IPublishedElement element).PublishedModelFactoryhas anIPublishedContenttype registered for the element content type, and thusCreateModel()fails here.Steps to reproduce
@Model.Value("nestedContentPropertyAlias")).Umbraco.ModelsBuilder.ModelsModetoLiveAppDatain<appSettings>.\src\Umbraco.Web.UI\App_Data\Models.\src\Umbraco.Web.UI\App_Data\Modelsin the Umbraco.Web.UI project.When ModelsBuilder runs in its default mode (PureLive) it works just fine.
Note: In V7 the Nested Content property value converter uses its own logic to convert the items to the concrete implementations of
IPublishedContent, which is why LiveAppData works in V7.What to do?
I think @zpqrtbnk is the right person to ask that š
In my opinion it makes sense to let Nested Content return
IPublishedElementitems. Question is ifPublishedModelFactorycan be tweaked to handle this case, and how it impacts the generated models (currently they can only be constructed fromIPublishedContent).Full stack trace
requires #4038