Mandatory field indication missing from Nested Content

[colin-tactuum]

Bug summary

When a field within nested content is set as mandatory, the red star to indicate it as mandatory is missing.

The correct error message is shown when you save the page, but client-side validation is not performed as it is when the field is outside of nested content.

Umbraco version

I am seeing this issue on Umbraco version: 8.3.0

Setup

---

Create a document type with a textstring. Set the textstring 'Field is mandatory' to true. Set the document type 'Is an Element type' to true. Save the document type.

Create a new data type. Set 'Nested Content' as the property editor. Set the Element type to the newly created document type (and set the Group accordingly). Save the data type.

In a document type (one that can be created as a node) Add a new property. Set the property name. Select the newly created data type from the editor list. Click on submit. Save the document type.

Steps to reproduce

Add an instance of the document type above. Add a new instance of the nested content property.

Expected result

The mandatory field should have a red star indicating it is mandatory.

Actual result

The mandatory field shows no indication of being mandatory.

[nul800sebastiaan]

Sure, just to note: this is not a new issue, this has always been in the case as far as I know of.

Have a look at this issue on the Nested Content tracker before it got integrated into the core of Umbraco: https://github.com/umco/umbraco-nested-content/issues/16

That issue describes (in part) the difficulties of implementing this kind of feature.

It doesn't seem like this type of validation is going to be trivial to implement, but we're happy for someone to have a go at it if they like a challenge.

[nul800sebastiaan]

Ah whoops, I think I managed to read more into this than you meant! While the feature to add a mandatory asterisk has not existed before, it should hopefully not be as hard to add as full client-side validation. Want to give it a go?

[umbrabot]

Hi @colin-tactuum,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

[kjac]

PR in #7217