Various Pre-values and Data not migrated

[benjaminc]

Overview

I came across some data that was not being migrated correctly for color pickers. On doing further investigate with a test database, I found multiple cases where pre-values were not correctly converted, and a few cases where data was not being correctly converted, all for Umbraco property editors.

Umbraco version

I am seeing this issue from Umbraco v7.15.3 to Umbraco v8.6.0

Bug summary

Various pre-values and some data values are not converted correctly.

Specifics

Using the test DB and media folder that can be found at https://proworkscorporation.sharepoint.com/:u:/s/ProWorks/Eaz2pIHhfpNEqhRd7sSIoGkBr3fUaW2QOWT4v7NO0o0g4g?e=xv3q5t

The following was not converted correctly:

• Pre-values

  1. Color Picker - Colors not converted
  2. Grid - RTE Code option is not converted to Source Code Editor
  3. Multinode Treepicker - Does not preserve "Allow items of type"
  4. Nested Content - Document Type and Tab are not converted to Element Type and Group properly
  5. Repeatable Textstrings - Does not preserve minimum and maximum values
  6. Slider - Does not preserve initial value, initial value 2, minimum value, maximum value, or step increments

• Data Values

  1. Nested Content
     • Checkbox List data is not converted
     • Dropdown data is not converted
     • Used document types are not marked as element data types

Steps to reproduce

1. Create an Umbraco v7.15.3 site.
2. Copy the media files from the attached file into the media folder
3. Import the database from the attached file
4. Point the Umbraco site at the imported database
5. Start the site, and view the back-office
6. In a new folder, create an Umbraco v8.6.0 site.
7. Copy the media files from the attached file into the media folder
8. Import the database from the attached file into a new database
9. Point the Umbraco site at the second imported database
10. Start the site, and allow it to upgrade
11. In the back-office, view the data types and compare with the v7.15.3 data types
12. In the back-office, view the content nodes and compare with the v7.15.3 site

Expected result

Data types pre-values should match when correlating pre-values exist in v8.

Content should be visible and match.

Actual result

Various data type pre-values do not match (see specifics above)

The Extended content page throws an error due to Nested Content data not being mapped properly, and cannot even be edited.

[benjaminc]

If anyone finding this wants to get fixes for these issues before the PR is merged, as well as a fix for #7914 which prevents you from going straight from v7 to v8.6+, you can use the ProWorks.Umbraco8.Migrations package (with source code here). It includes fixes for both issues while the PRs for them are under review.

[umbrabot]

Closing this in relation to #7957 - make sure to read the close reason on #7957