Strongly typed model updates not discovered by new Cloud sites at runtime

[Jay-umbr]

Issue description

Tested on the Cloud Umbraco 8.16.0 Deploy 4.1.3 Forms 8.7.6

A brand new project. By default all Cloud sites use ModelsBuilder in pureLive mode. When using published models/ strongly typed models in views, and adding new properties on document types, it would seem that changes made to the strongly typed models are not picked up by the website automatically. Which means if you add a new property "Number" to your Product page, and in the template render it as Model.Number, you might get a YSOD:

What goes wrong? The property exists on the document type, can be render by using the .Value() method, it is just the PublishedModels namespace that seemingly does not update.

An environment restart fixes the YSOD.

Steps to reproduce:

1. Make a new Cloud site
2. Add a new Homepage doctype
3. Add some properties to it
4. In the template make sure to include @using ContentModels = Umbraco.Web.PublishedModels;
5. Render your properties in a strongly typed way (Model.Header etc)
6. Create content if you have not done so already
7. Visit the homepage
8. It should throw a YSOD saying HomePage does not contain a definition for Header

Expected result Models Builder rebuilds the model of the doctype after any change you make to properties and these models are available instantly to render content in a strongly typed manner

Actual result

Adding any new property to any existing document type and rendering said property strongly typed results in YSOD

[greystate]

I've been seeing this for quite a while - so much that I've probably internalized restarting the site after any doctype changes - which shouldn't be the case.

[sitereactor]

@greystate For how long? I'm be curious to know if you've experienced this on the old platform as well as the new? Maybe for certain versions of Umbraco? 🤔

[greystate]

@sitereactor I am going to say definitely before the migration; my own interpretation has sort of been "that happened with the stripped-down version of Models Builder" but I have no idea if that's actually true or not.

I can say I have sites running today on both platforms where it's happening as regularly as clockwork (assuming the s1 URLs indicate "old platform" and euwest01 states "new platform"). I will be happy to provide you with project names for further scrutiny.

[rhealefever]

@sitereactor We've experienced it in the Fundamentals course for a while - on the old platform - but there never seemed to be a pattern to it, it was something that happened to some projects and not others. I've always written it off as a good example of why not to develop directly on your live environment, to work with a local clone of it instead if it's your only Cloud environment.

Since the migration to the new platform, it happens consistently to all projects. So every time we make doctype changes, we all have to restart our environments to avoid a YSOD on the frontend.

[umbrabot]

Hiya @Jay-umbr,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: