search

umbraco / Umbraco.Cloud.Issues

Public issue tracker for Umbraco Cloud
24 stars 2 forks source link

Auto upgrades break when using Central Package Management #726

Closed jemayn closed 4 months ago

jemayn commented 5 months ago

Issue description

We recently switched to using Central Package Management on a larger project as it had several projects within it.

What this means is we removed all versions of package references within csproj files and listed them all in a Directory.Packages.props file. It works fine locally and in Azure pipelines for building, and it works fine with the cloud build as well.

It seems though with the latest auto upgrade that it failed - my assumption is because the csproj no longer has a version listed and it needs to be set in the global file in the root of the repo.

Additionally the cloud portal threw this error: image

Looks like the upgrade failed before doing anything, as the files are unchanged and no commits were made.

sajumb commented 5 months ago

Hi @jemayn, We will investigate this issue with the auto-upgrade process in the context of Central Package Management and provide an update as soon as we have more information. Thank you for bringing this to our attention.

mclausen commented 4 months ago

Hi @jemayn First, thank you for the feedback, and yes you assumed correctly that the the previous revision of auto-upgrader did not support such gem as a feature as Central Package management. However, we have been running it internally for around two weeks and it seems to work exactly how it is supposed to, so you'll find, that if your project uses CPM, then your project will also get upgraded next time 👯 🐎 🙌 .

Thank you again for reporting :)

jemayn commented 4 months ago

Hey @mclausen

Thanks for the quick work! 🙂

I did notice our most recent auto upgrade went through with no issues.