umbraco / Umbraco.Cms.Integrations

MIT License
36 stars 21 forks source link

Semrush Keyword Search #155

Closed wjamieson closed 9 months ago

wjamieson commented 9 months ago

Umbraco Version: 8.18.7 Umbraco.Cms.Integrations.SEO.Semrush Version: 1.2.2

Config variables: Umbraco.Cms.Integrations.SEO.Semrush.BaseUrl: "https://oauth.semrush.com/" Umbraco.Cms.Integrations.SEO.Semrush.UseUmbracoAuthorization: "true"

I've configured and authenticated the Semrush plugin however the keyword search function does not work, getting an unhandled JS error every time it runs.

Semrush has apparently authenticated correctly, however all keyword searches stop almost instantly with no results grid appearing. Upon inspection of the browser console I can see that the code is falling over attempting to read "isSuccessful" from the result of the call to umbracoCmsIntegrationsSemrushResource.getRelatedPhrases. The result from this call is null which causes the JavaScript to break when parsing the response.

Pressing the Status button I have the following values: Connected: True Account: N.A. Access Token: [token string]

Is there any additional config required either in Umbraco or Semrush for this? I'm unsure whether the account showing as N.A. is an issue or not.

Thanks


This item has been added to our backlog AB#35911

acoumb commented 9 months ago

Hi @wjamieson ,

Could you provide me more details on your use case, maybe a screenshot of the error? I made a test on an Umbraco 8.18.9 instance, with version 1.2.2 of Semrush, and I did not encounter any issues. You can check my demo here. I've used the same settings you had.

Thank you, Adrian

wjamieson commented 9 months ago

Hi @acoumb ,

I appreciate the quick response on this but we've managed to resolve the problem! Initially when we configured the plugin and authenticated against Semrush we didn't have the BaseURL config value set. We corrected this but still couldn't get the plugin to work which was when I raised the ticket.

Since then we've revoked and re-authenticated using the controls in the content app and that was when it started working.

Thanks again for taking a look at this!

Cheers, William