umbraco / Umbraco.Cms.Integrations

MIT License
31 stars 20 forks source link

Algolia - TinyMCE not indexed in Umbraco 13 with 2.1.4 Algolia #188

Closed gardarthorsteins closed 2 months ago

gardarthorsteins commented 2 months ago

When indexing TinyMCE properties the value is always return empty to algolia.

This line here is the problem inside of AlgoliaSearchPropertyIndexValueFactory

var indexValues = propertyEditor.PropertyIndexValueFactory.GetIndexValues(property, culture, null, true);

The values are in the property but indexValues return empty string.

I'm guessing the issue is the Umbraco update to the TinyMCE property lately, it returns an json object now instead of a string.

I was hoping to fix the problem temporarily by creating a converter for TinyMCE properties but I would need the property data be passed into it to work with the values my self.

I think that passing the property to the converter would be very powerful so we could not only do specific thing with property editors but also target specific ones with the alias or use the raw values or self.

acoumb commented 2 months ago

Hi @gardarthorsteins ,

I have included this update with today's 2.1.5 patch release of Algolia.

Thanks, Adrian