umbraco / Umbraco.Cms.Integrations

MIT License
31 stars 20 forks source link

Feature/algolia v14 #193

Closed acoumb closed 1 week ago

acoumb commented 3 weeks ago

Current PR contains the updates for Umbraco 14 for Algolia integration, with some bugfixes and design updates.

This is also to get feedback on the release-ready status of the integration based on your experience with the other products.

acoumb commented 2 weeks ago

Fixed api resources generation by using the Swagger JSON schema on http instead of https, and updated all references.

nathanwoulfe commented 1 week ago

Looks like I've made a stack of changes, but most of it is just linting/style to align with the other products.

Couple of remaining things to consider:

Long story short, this is looking great and ready to go (things to consider above can be done at any time, if we want to)

acoumb commented 1 week ago

@nathanwoulfe I've removed the data source and moved the logic and error handling to the repository scope. Also I made some small fixes along the way. Could you have a quick look over things now before merging them? Thank you.

nathanwoulfe commented 1 week ago

@acoumb looks good to me - I made a couple more changes