Closed acoumb closed 1 week ago
Fixed api resources generation by using the Swagger JSON schema on http
instead of https
, and updated all references.
Looks like I've made a stack of changes, but most of it is just linting/style to align with the other products.
GetContentTypesController
had an endpoint method named GetContentTypes
and a private method with the same name accepting an optional int ID argument. Former attempted to call the later, but fell into a self-referencing loop. Renamed a couple of methods and we're all good.Couple of remaining things to consider:
await this.#algoliaIndexContext?.getIndices()
.then(response => {
this._indices = response as Array<IndexConfigurationModel>;
this._loading = false;
})
.catch(error => this.#showError(error.message));
can use async/await without the callbacks:
this._indices = await this.#algoliaIndexContext?.getIndices();
this._loading = false;
Long story short, this is looking great and ready to go (things to consider above can be done at any time, if we want to)
@nathanwoulfe I've removed the data source and moved the logic and error handling to the repository scope. Also I made some small fixes along the way. Could you have a quick look over things now before merging them? Thank you.
@acoumb looks good to me - I made a couple more changes
umb-property-layout
rather than the form layout, it is styled better for the backoffice
Current PR contains the updates for Umbraco 14 for
Algolia
integration, with some bugfixes and design updates.This is also to get feedback on the release-ready status of the integration based on your experience with the other products.